Fix Mageblood mods merging in item crafter#2186
Merged
Merged
Conversation
We currently only check if a variant is active to add the variants mod which is why selecting the same variant twice only shows 1 mod on the item Added a flag that overwrites this behaviour so they don't get merged on Mageblood
bct8925
pushed a commit
to bct8925/PathOfBuilding-PoE2
that referenced
this pull request
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
We currently only check if a variant is active to add the variants mod which is why selecting the same variant twice only shows 1 mod on the item
Added a flag that overwrites this behaviour so they don't get merged on Mageblood
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/7k1awa0w
Before screenshot:
After screenshot: